[fix][core] always expose stse_get_ecc_key_type_from_curve_id - #110
Merged
Merged
Conversation
TofMassilia13320
self-requested a review
September 3, 2026 12:23
TofMassilia13320
approved these changes
Sep 3, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to removing a compile guard and remains consistent with the always-present stse_ecc_info_table fallback and enum behavior when no ECC curves are configured.
Pull request overview
This PR ensures the core helper stse_get_ecc_key_type_from_curve_id() is always compiled and linkable, regardless of which ECC curve macros are enabled, so downstream code can rely on the symbol being present.
Changes:
- Removed the preprocessor guard around
stse_get_ecc_key_type_from_curve_id()so it is always built.
File summaries
| File | Description |
|---|---|
| core/stse_generic_typedef.c | Removes conditional compilation around stse_get_ecc_key_type_from_curve_id() to always expose the API. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Grom-
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.